Fix null safety in filepickerdelegate #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| outputStream.write(bytes); | ||
| outputStream.flush(); | ||
| outputStream.close(); | ||
| if (data != null) { |
There was a problem hiding this comment.
Can you use an early return instead?
Lilian-C
force-pushed
the
fix-file-picker-delegate-nullsafety
branch
from
e0c9603
to
0bcc22d
Compare
Lilian-C
force-pushed
the
fix-file-picker-delegate-nullsafety
branch
from
0bcc22d
to
141cc3f
Compare
| @@ -85,6 +85,8 @@ public boolean onActivityResult(final int requestCode, final int resultCode, fin | |||
| // Save file | |||
| if (requestCode == SAVE_FILE_CODE) { | |||
| if (resultCode == Activity.RESULT_OK) { | |||
| if (data == null) | |||
There was a problem hiding this comment.
Since the other if's also use curly braces, can you do that here as well?
Also, if you update the patch version and add an entry in the changelog, then this can be published.
Lilian-C
force-pushed
the
fix-file-picker-delegate-nullsafety
branch
from
e945fa3
to
e090801
Compare
navaronbracke
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.